thijn/SqMod
1
0
Fork 0
mirror of https://github.com/VCMP-SqMod/SqMod.git synced 2025-06-15 22:57:12 +02:00
Code Releases Activity

Implement a new module command that is called right before cosing the virtual machine to allow modules to release resources manually.

Browse Source 
Should fix a possible crash in the IRC plugin which was caused by the Session destructor to be called recursively when cleaned automatically by the VM.
This commit is contained in:
Sandu Liviu Catalin
2016-09-02 14:11:39 +03:00
parent e23e5d0a05
commit e445530bbb
11 changed files with 104 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
modules/irc/Module.cpp
View File

@ -99,6 +99,15 @@ static void OnSquirrelTerminate()
NullFunction().ReleaseGently();
}
/* ------------------------------------------------------------------------------------------------
* The virtual machined is about to be closed. Last chance to release anything manually.
*/
static void OnSquirrelClosing()
{
// Terminate all sessions, if any
SessionTerminate();
}
/* ------------------------------------------------------------------------------------------------
* The virtual machined was closed and all memory associated with it was released.
*/
@ -106,8 +115,6 @@ static void OnSquirrelReleased()
{
// Release the current virtual machine, if any
DefaultVM::Set(nullptr);
// Terminate all sessions, if any
SessionTerminate();
}
/* ------------------------------------------------------------------------------------------------
@ -141,6 +148,10 @@ static uint8_t OnPluginCommand(uint32_t command_identifier, CCStr message)
{
OnSquirrelTerminate();
} break;
case SQMOD_CLOSING_CMD:
{
OnSquirrelClosing();
} break;
case SQMOD_RELEASED_CMD:
{
OnSquirrelReleased();

2
modules/irc/Session.cpp
View File

@ -202,7 +202,9 @@ void Session::Destroy()
{
// Make sure there's even a session to release
if (!m_Session)
{
return;
}
// Disconnect the session
Disconnect();
// Break the association with this instance (paranoia)