thijn/SqMod
1
0
Fork 0
mirror of https://github.com/VCMP-SqMod/SqMod.git synced 2025-01-19 03:57:14 +01:00
Code Releases Activity

Move the resource releasing from the IRC Session type to it's destructor.

Browse Source
This commit is contained in:
Sandu Liviu Catalin 2015-10-31 21:25:40 +02:00
parent 1a34efb45b
commit a2a02a6c9d
2 changed files with 26 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
source/Library/IRC/Session.cpp
View File

@ -31,8 +31,6 @@ Session::Session() noexcept
// Connect to the on frame event so we can process callbacks // Connect to the on frame event so we can process callbacks
_Core->ServerFrame.Connect< Session, &Session::Process >(this); _Core->ServerFrame.Connect< Session, &Session::Process >(this);
} }
// Receive notification when the VM is about to be closed to release object references
_Core->VMClose.Connect< Session, &Session::VMClose >(this);
} }
// ------------------------------------------------------------------------------------------------ // ------------------------------------------------------------------------------------------------
@ -44,10 +42,32 @@ Session::~Session()
irc_destroy_session(m_Session); irc_destroy_session(m_Session);
m_Session = nullptr; m_Session = nullptr;
} }
// Disconenct from the on frame event // Disconnect from the on frame event
_Core->ServerFrame.Disconnect< Session, &Session::Process >(this); _Core->ServerFrame.Disconnect< Session, &Session::Process >(this);
// Stop receiving notification when the VM is about to be closed // Release the reference to the specified callback
_Core->VMClose.Disconnect< Session, &Session::VMClose >(this); m_OnConnect.Release2();
m_OnNick.Release2();
m_OnQuit.Release2();
m_OnJoin.Release2();
m_OnPart.Release2();
m_OnMode.Release2();
m_OnUmode.Release2();
m_OnTopic.Release2();
m_OnKick.Release2();
m_OnChannel.Release2();
m_OnPrivMSG.Release2();
m_OnNotice.Release2();
m_OnChannel_Notice.Release2();
m_OnInvite.Release2();
m_OnCTCP_Req.Release2();
m_OnCTCP_Rep.Release2();
m_OnCTCP_Action.Release2();
m_OnUnknown.Release2();
m_OnNumeric.Release2();
m_OnDcc_Chat_Req.Release2();
m_OnDcc_Send_Req.Release2();
// Release the reference to the specified user data
m_Data.Release();
} }
// ------------------------------------------------------------------------------------------------ // ------------------------------------------------------------------------------------------------
@ -86,35 +106,6 @@ void Session::Process(SQFloat delta) noexcept
} }
} }
// ------------------------------------------------------------------------------------------------
void Session::VMClose() noexcept
{
// Release the reference to the specified callback
m_OnConnect.Release2();
m_OnNick.Release2();
m_OnQuit.Release2();
m_OnJoin.Release2();
m_OnPart.Release2();
m_OnMode.Release2();
m_OnUmode.Release2();
m_OnTopic.Release2();
m_OnKick.Release2();
m_OnChannel.Release2();
m_OnPrivMSG.Release2();
m_OnNotice.Release2();
m_OnChannel_Notice.Release2();
m_OnInvite.Release2();
m_OnCTCP_Req.Release2();
m_OnCTCP_Rep.Release2();
m_OnCTCP_Action.Release2();
m_OnUnknown.Release2();
m_OnNumeric.Release2();
m_OnDcc_Chat_Req.Release2();
m_OnDcc_Send_Req.Release2();
// Release the reference to the specified user data
m_Data.Release();
}
// ------------------------------------------------------------------------------------------------ // ------------------------------------------------------------------------------------------------
irc_callbacks_t * Session::GetCallbacks() noexcept irc_callbacks_t * Session::GetCallbacks() noexcept
{ {
@ -1738,7 +1729,7 @@ bool Register_IRC(HSQUIRRELVM vm)
ircns.Func(_SC("GetErrStr"), &irc_strerror); ircns.Func(_SC("GetErrStr"), &irc_strerror);
// Output debugging information // Output debugging information
LogDbg("Registration of <IRC functions> type was successful"); LogDbg("Registration of <IRC functions> type was successful");
// Attempt to bind verything to the root table // Attempt to bind everything to the root table
Sqrat::RootTable(vm).Bind(_SC("IRC"), ircns); Sqrat::RootTable(vm).Bind(_SC("IRC"), ircns);
// Output debugging information // Output debugging information
LogDbg("Beginning registration of <IRC Constants> type"); LogDbg("Beginning registration of <IRC Constants> type");

5
source/Library/IRC/Session.hpp
View File

@ -91,11 +91,6 @@ public:
*/ */
void Process(SQFloat delta) noexcept; void Process(SQFloat delta) noexcept;
/* --------------------------------------------------------------------------------------------
* ...
*/
void VMClose() noexcept;
/* -------------------------------------------------------------------------------------------- /* --------------------------------------------------------------------------------------------
* ... * ...
*/ */