thijn/SqMod
1
0
Fork 0
mirror of https://github.com/VCMP-SqMod/SqMod.git synced 2025-01-31 18:07:14 +01:00
Code Releases Activity

Don't call the debugger explicitly where implicitly called.

Browse Source
This commit is contained in:
Sandu Liviu Catalin 2016-08-26 17:38:38 +03:00
parent e953406b7f
commit 9fcb65f63d
2 changed files with 5 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
source/Command.cpp
View File

@ -394,8 +394,6 @@ Int32 Controller::Exec(Context & ctx)
ctx.mBuffer.Write(0, e.what(), e.Message().size()); ctx.mBuffer.Write(0, e.what(), e.Message().size());
// Specify that the command execution failed // Specify that the command execution failed
failed = true; failed = true;
// Call the debugger on this error and see if it can find anything
Logger::Get().Debug("%s", e.what());
} }
} }
else else
@ -418,8 +416,6 @@ Int32 Controller::Exec(Context & ctx)
ctx.mBuffer.Write(0, e.what(), e.Message().size()); ctx.mBuffer.Write(0, e.what(), e.Message().size());
// Specify that the command execution failed // Specify that the command execution failed
failed = true; failed = true;
// Call the debugger on this error and see if it can find anything
Logger::Get().Debug("%s", e.what());
} }
} }
// Was there a runtime exception during the execution? // Was there a runtime exception during the execution?
@ -437,10 +433,8 @@ Int32 Controller::Exec(Context & ctx)
} }
catch (const Sqrat::Exception & e) catch (const Sqrat::Exception & e)
{ {
// Call the debugger on this error and see if it can find anything
Logger::Get().Debug("%s", e.what());
// Tell the script callback to deal with the error // Tell the script callback to deal with the error
SqError(CMDERR_UNRESOLVED_FAILURE, _SC("Unable to resolve command failure"), e.Message()); SqError(CMDERR_UNRESOLVED_FAILURE, _SC("Unable to resolve command failure"), e.what());
} }
} }
// Result is invalid at this point // Result is invalid at this point
@ -461,10 +455,8 @@ Int32 Controller::Exec(Context & ctx)
} }
catch (const Sqrat::Exception & e) catch (const Sqrat::Exception & e)
{ {
// Call the debugger on this error and see if it can find anything
Logger::Get().Debug("%s", e.what());
// Tell the script callback to deal with the error // Tell the script callback to deal with the error
SqError(CMDERR_UNRESOLVED_FAILURE, _SC("Unable to resolve command failure"), e.Message()); SqError(CMDERR_UNRESOLVED_FAILURE, _SC("Unable to resolve command failure"), e.what());
} }
} }
} }
@ -478,10 +470,8 @@ Int32 Controller::Exec(Context & ctx)
} }
catch (const Sqrat::Exception & e) catch (const Sqrat::Exception & e)
{ {
// Call the debugger on this error and see if it can find anything
Logger::Get().Debug("%s", e.what());
// Tell the script callback to deal with the error // Tell the script callback to deal with the error
SqError(CMDERR_POST_PROCESSING_FAILED, _SC("Unable to complete command post processing"), e.Message()); SqError(CMDERR_POST_PROCESSING_FAILED, _SC("Unable to complete command post processing"), e.what());
} }
} }
// Return the result // Return the result

5
source/Command.hpp
View File

@ -413,9 +413,8 @@ protected:
} }
catch (const Sqrat::Exception & e) catch (const Sqrat::Exception & e)
{ {
LogErr("Command error callback failed"); // The debugger probably took care of reporting the details
// Call the debugger on this error and see if it can find anything LogErr("Command error callback failed [%s]", e.what());
Logger::Get().Debug("%s", e.what());
} }
} }