thijn/SqMod
1
0
Fork 0
mirror of https://github.com/VCMP-SqMod/SqMod.git synced 2024-11-08 08:47:17 +01:00
Code Releases Activity

Reduce the task parameters to 8.

Browse Source 
Remove the Self property from the tasks because it's useless.
This commit is contained in:
Sandu Liviu Catalin 2016-11-17 12:59:29 +02:00
parent a04fd3ba15
commit 2449a44c1f
2 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
source/Tasks.cpp
View File

@ -157,7 +157,6 @@ void Tasks::Register(HSQUIRRELVM vm)
.SquirrelFunc(_SC("_typename"), &Typename::Fn) .SquirrelFunc(_SC("_typename"), &Typename::Fn)
.Func(_SC("_tostring"), &Task::ToString) .Func(_SC("_tostring"), &Task::ToString)
// Properties // Properties
.Prop(_SC("Self"), &Task::GetSelf)
.Prop(_SC("Inst"), &Task::GetInst) .Prop(_SC("Inst"), &Task::GetInst)
.Prop(_SC("Func"), &Task::GetFunc, &Task::SetFunc) .Prop(_SC("Func"), &Task::GetFunc, &Task::SetFunc)
.Prop(_SC("Data"), &Task::GetData, &Task::SetData) .Prop(_SC("Data"), &Task::GetData, &Task::SetData)
@ -223,7 +222,7 @@ SQInteger Tasks::Create(Int32 id, Int32 type, HSQUIRRELVM vm)
// Grab the top of the stack // Grab the top of the stack
const SQInteger top = sq_gettop(vm); const SQInteger top = sq_gettop(vm);
// See if too many arguments were specified // See if too many arguments were specified
if (top > 18) /* 4 base + 14 parameters = 18 */ if (top > 12) /* 4 base + 8 parameters = 12 */
{ {
return sq_throwerror(vm, "Too many parameter specified"); return sq_throwerror(vm, "Too many parameter specified");
} }

10
source/Tasks.hpp
View File

@ -40,7 +40,7 @@ private:
Int16 mEntity; // The identifier of the entity to which is belongs. Int16 mEntity; // The identifier of the entity to which is belongs.
Uint8 mType; // The type of the entity to which is belongs. Uint8 mType; // The type of the entity to which is belongs.
Uint8 mArgc; // The number of arguments that the task must forward. Uint8 mArgc; // The number of arguments that the task must forward.
Argument mArgv[14]; // The arguments that the task must forward. Argument mArgv[8]; // The arguments that the task must forward.
/* ---------------------------------------------------------------------------------------- /* ----------------------------------------------------------------------------------------
* Default constructor. * Default constructor.
@ -136,14 +136,6 @@ private:
*/ */
Interval Execute(); Interval Execute();
/* ----------------------------------------------------------------------------------------
* Retrieve the instance to self.
*/
const LightObj & GetSelf() const
{
return mSelf;
}
/* ---------------------------------------------------------------------------------------- /* ----------------------------------------------------------------------------------------
* Retrieve the instance to entity instance. * Retrieve the instance to entity instance.
*/ */